Fix unit tests #116
Merged
Fix unit tests #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
pushed a commit
that referenced
this pull request
Aug 8, 2018
- add missing parameters to testCUDAService - add cudaChecks and synchronizations to test_GPUSimpleVector - remove obsolete testCUDAServiceDrv
bkilian15
pushed a commit
to bkilian15/cmssw
that referenced
this pull request
May 15, 2019
…niAOD Sync with 10_5_X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rebasing #100 I noticed some of our unit test no longer run, this PR fixes them:
testCUDAServicefor the parameters added in Extend the CUDAService to support CUDA device flags and limits #103testCUDAServiceDrvas obsoletetest_GPUSimpleVector, but that went away after I decorated all calls there withcudaCheck()cudaDeviceSynchronize()after all kernel launches